Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relax size check #36

Merged
merged 3 commits into from
Oct 4, 2020
Merged

relax size check #36

merged 3 commits into from
Oct 4, 2020

Conversation

jasperzhong
Copy link

refer to dmlc#167

this is a must for gradient compression.

@jasperzhong jasperzhong mentioned this pull request Jul 8, 2020
Merged
8 tasks
@jasperzhong
Copy link
Author

I think this PR should be merged? Since bytedance/byteps#225 has been merged.

@ymjiang

@ymjiang ymjiang merged commit c62cca0 into bytedance:byteps Oct 4, 2020
@ymjiang
Copy link
Member

ymjiang commented Oct 4, 2020

Merged. Sorry for the delay.

@jasperzhong jasperzhong deleted the patch branch October 4, 2020 12:45
@jasonliu747
Copy link

jasonliu747 commented Nov 27, 2020 •
edited
Loading

@ymjiang FYI, submodule in byteps is still detached at 2f40b17 which doesn't cover this update.

@ymjiang
Copy link
Member

ymjiang commented Nov 27, 2020

@ymjiang FYI, submodule in byteps is still detached at 2f40b17 which doesn't cover this update.

Will fix this in bytedance/byteps#326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasperzhong @ymjiang @jasonliu747